Setting first responder on an accessibility element may be delayed #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phatmann
added a commit
that referenced
this pull request
Jan 22, 2016
…st-responder-change-is-immediate Setting first responder on an accessibility element may be delayed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a case where we're tapping an element that displays a popover control, and it doesn't report as being firstResponder until after the popover has been displayed (on the next runloop cycle). Using KIFTestCondition here meant that we'd fail the immediate check, despite the element becoming first responder shortly thereafter.
The fix here is to allow the element to become first responder shortly after being tapped. This will make failures take a little longer (I limited it to a half second) if the element is tapped and doesn't ever become first responder.